Open datvm opened 1 year ago
We need to add formDisabledCallback()
to our elements, since <fieldset>
can disable them
formDisabledCallback(disabled: boolean) {
this.disabled = disabled;
}
This would be a good community PR, want to take a stab at it?
Sure I can do that :)
This is fixed now in 1.1 :)
I not sure this is just a workaround or completely fix. The behavior is wrong due to, https://github.com/material-components/material-web/pull/5053#discussion_r1344784951. The component should not set disabled
to itself. Moreover, when <fieldset>
is changed back to enabled
state, the <text-field>
is not changed back to enabled
.
Interesting! After investigating, I believe the problem is that setting our own disabled
attributes changes the underlying disabled state of the FACE.
Instead, we need to handle an internal disabled state and a client-facing disabled
attribute state.
What is affected?
Component
Description
See: https://jsfiddle.net/datvm/zdpeqc5j/1/
For standard components, when an acestor
<fieldset>
has[disabled=true]
, they are disabled as well. I think this behavior is not discussed yet so it's probably not a bug? Would you consider adding this feature?Note: the screenshot above misses
<md-select>
.Reproduction
https://jsfiddle.net/datvm/zdpeqc5j/1/
Workaround
You have to manually set
disabled
to each component in thefieldset
.Is this a regression?
No or unsure. This never worked, or I haven't tried before.
Affected versions
1.0.0
Browser/OS/Node environment
-