material-components / material-web

Material Design Web Components
https://material-web.dev
Apache License 2.0
8.71k stars 818 forks source link

md-slider track background #5518

Closed TeamBusylj closed 2 months ago

TeamBusylj commented 2 months ago

What is affected?

Theming

Description

Hi, I want to set slider tick's color tolinear-gradient with setting --_active-track-color variable to gradient. But it doesn't work because the variable sets background-color of tick instead of background. background-color doesnt support linear gradient. Is there a way to bypass or fix it?

Reproduction

It doesn't work.

Workaround

I have not found a workaround.

Is this a regression?

No or unsure. This never worked, or I haven't tried before.

Affected versions

1.0.3

Browser/OS/Node environment

All platforms

asyncLiz commented 2 months ago

Can you provide some screenshots of the design you're trying to achieve? The tick marks are very small, so I'm not sure a linear gradient would be perceivable.

TeamBusylj commented 2 months ago

Hi, i have changed track-height variable to it is taller. This is how it looks like when i set background to gradient in devtools. This is the design i want to achive, but as said background-color css property doesnt support gradient. image

Where is green underline it has to be background instead of background color: image

asyncLiz commented 2 months ago

Gotcha, thanks for the screenshot! Cute slider!

Changing places we're using background-color to background makes sense to me. Could you send a PR?

TeamBusylj commented 2 months ago

Hi i have created pull request and committed it, but I'm not authorized user.

On Fri, Mar 8, 2024, 20:58 Elizabeth Mitchell @.***> wrote:

Gotcha, thanks for the screenshot! Cute slider!

Changing places we're using background-color to background makes sense to me. Could you send a PR?

— Reply to this email directly, view it on GitHub https://github.com/material-components/material-web/issues/5518#issuecomment-1986336770, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVDSXLWTRYQDE5X7Z5QQBGTYXIJ6FAVCNFSM6AAAAABEJRN7SWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOBWGMZTMNZXGA . You are receiving this because you authored the thread.Message ID: @.***>

asyncLiz commented 2 months ago

Thanks! I'm reviewing it now :)

TeamBusylj commented 2 months ago

Thanks:)

On Tue, 12 Mar 2024, 18:28 copybara-service[bot], @.***> wrote:

Closed #5518 https://github.com/material-components/material-web/issues/5518 as completed via #5521 https://github.com/material-components/material-web/pull/5521.

— Reply to this email directly, view it on GitHub https://github.com/material-components/material-web/issues/5518#event-12092771817, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVDSXLTVCJP4KO4TLXNEOHLYX43KVAVCNFSM6AAAAABEJRN7SWVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJSGA4TENZXGE4DCNY . You are receiving this because you authored the thread.Message ID: <material-components/material-web/issue/5518/issue_event/12092771817@ github.com>