search

material-extensions / material-icons-browser-extension

Browser Addon that enhances file browsers of version controls with material icons.
MIT License
524 stars 39 forks source link

Support Firefox #1

Closed Samuel-Martineau closed 3 years ago

Samuel-Martineau commented 3 years ago

Do you have any intention to publish this extension to the Firefox addons marketplace?

Claudiohbsantos commented 3 years ago

(I think I might have answered you on reddit just now)

I wasn't planning to but mostly because I hadn't even thought about that. I have never looked into developing extensions for firefox so I can't tell for sure but I think it should be a pretty straight forward port. If enough people show interest I'd be more than happy to research that. Also very happy to take Pull Requests for that into this repo if you happen to have experience with that.

Samuel-Martineau commented 3 years ago

It wasn't me who asked you about it on Reddit... Also, if I remember correctly, Firefox extensions are the same as Chrome extensions.

https://extensionworkshop.com/documentation/publish/package-your-extension/

Claudiohbsantos commented 3 years ago

Oh, sorry, both messages came in pretty much at the same time so I thought it might be the same request.

Thanks for the link, that looks promising. Their compatibility tested actually reports the extension is compatible already so I'll try running it on firefox later today when I get a chance and if it works I'll try adding it to the firefox extensions

Claudiohbsantos commented 3 years ago

Managed to add it to the firefox store: https://addons.mozilla.org/en-US/firefox/addon/material-icons-for-github/

thanks for the pointers!

I ran a quick test on firefox and it looks like it's running without a problem, but please don't hesitate to let me know if you notice any weirdness. Since that's not my main browser I won't use it enough to notice any quirks

callmetwan commented 3 years ago

Wow, this was fast, thank you!!

Samuel-Martineau commented 3 years ago

Thanks!

ehmicky commented 3 years ago

This is great! You might consider adding the https://addons.mozilla.org/en-US/firefox/addon/material-icons-for-github/ URL to the README.md :)

Claudiohbsantos commented 3 years ago

Yeah, that is on the todo list for today. Just need to see if they have a badge I can use to keep the look similar to what is currently on the readme for the chrome web store.

pokedotdev commented 3 years ago

The extension is no longer available in the Firefox add-on market.

Screenshot 2021-07-10 at 20 33 56

Claudiohbsantos commented 3 years ago

@arturoeh 🙈 I was racing to try to finish the last changes before updating the add-on. Looks like I lost the race, sorry.

I just submitted an updated version to the store, it is currently awaiting review (last time it took 1 day)

I also just pushed new github actions that should automatically update the store on new upstream versions, so this shouldn't happen again

othmanabdulsalam commented 2 years ago

@Claudiohbsantos Any updates on the firefox addon. At the moment it still doesnt appear on the store.

Claudiohbsantos commented 2 years ago

I just finished a new version that should make it simpler for the extension to go through their review process. It's in the queue now, let's see how that goes 🤞

I'll check/answer any followup in #26 since that issue is still open. Feel free to followup there if it's not live/working in about a week.

Thanks for the reminder :)