material-extensions / material-icons-browser-extension

Browser Addon that enhances file browsers of version controls with material icons.
MIT License
511 stars 38 forks source link

Revert "WSL support" - #17

Closed Claudiohbsantos closed 3 years ago

Claudiohbsantos commented 3 years ago

Reverts Claudiohbsantos/github-material-icons-extension#16

@shivapoudel

Unfortunately I jumped the gun merging the PR. The new version of parcel doesn't seem to work on Windows (testing with node 14.16.1) .

Since the changes are non-critical to a release I am reverting the merge in order to cut a manual release and then we can address these later

Errors:

to log errors, add .catch(console.error) to the end of line 11 in build-src.js (I'll add this to the codebase, it's just easier to manually add here than mucking with branches)

with with versions in PR:

[2/2] Bundle extension manifest, images and main script.
[ThrowableDiagnostic [Error]: Invalid Parcel Config] {
  diagnostics: [
    {
      message: 'Invalid Parcel Config',
      origin: '@parcel/core',
      filePath: 'node_modules\\@parcel\\config-default\\index.json',
      language: 'json',
      codeFrame: [Object]
    }
  ]
}

with latest versions: parcel 2.0.0-beta.3.1 & @parcel/config-default 2.0.0-beta.3.1:

[2/2] Bundle extension manifest, images and main script.
AssertionError [ERR_ASSERTION]: Bundles must have unique names
    at BundlerRunner.nameBundles (U:\Dev\github-material-icons-extension\node_modules\@parcel\core\lib\requests\BundleGraphRequest.js:482:23)
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
    at async BundlerRunner.bundle (U:\Dev\github-material-icons-extension\node_modules\@parcel\core\lib\requests\BundleGraphRequest.js:434:5)
    at async RequestTracker.runRequest (U:\Dev\github-material-icons-extension\node_modules\@parcel\core\lib\RequestTracker.js:694:20)
    at async Parcel._build (U:\Dev\github-material-icons-extension\node_modules\@parcel\core\lib\Parcel.js:661:25)
    at async Parcel.run (U:\Dev\github-material-icons-extension\node_modules\@parcel\core\lib\Parcel.js:510:18)
    at async Promise.all (index 2) {
  diagnostics: [
    {
      origin: 'Error',
      message: 'Bundles must have unique names',
      name: 'AssertionError',
      filePath: undefined,
      stack: 'AssertionError [ERR_ASSERTION]: Bundles must have unique names\n' +
        '    at BundlerRunner.nameBundles (U:\\Dev\\github-material-icons-extension\\node_modules\\@parcel\\core\\lib\\requests\\BundleGraphRequest.js:482:23)\n' +
        '    at processTicksAndRejections (internal/process/task_queues.js:93:5)\n' +
        '    at async BundlerRunner.bundle (U:\\Dev\\github-material-icons-extension\\node_modules\\@parcel\\core\\lib\\requests\\BundleGraphRequest.js:434:5)\n' +
        '    at async RequestTracker.runRequest (U:\\Dev\\github-material-icons-extension\\node_modules\\@parcel\\core\\lib\\RequestTracker.js:694:20)\n' +
        '    at async Parcel._build (U:\\Dev\\github-material-icons-extension\\node_modules\\@parcel\\core\\lib\\Parcel.js:661:25)\n' +
        '    at async Parcel.run (U:\\Dev\\github-material-icons-extension\\node_modules\\@parcel\\core\\lib\\Parcel.js:510:18)\n' +
        '    at async Promise.all (index 2)',
      codeFrame: undefined
    }
  ],
  name: 'BuildError'
}
shivapoudel commented 3 years ago

CC @4086606

ghost commented 2 years ago

I did read this previously but didn't know Parcel 2 was broken for the config change in Windows. Good call though. Maybe it's stabler now?