material-extensions / material-icons-browser-extension

Browser Addon that enhances file browsers of version controls with material icons.
MIT License
511 stars 38 forks source link

Firefox: Unable to Install: Appears to be corrupt #23

Closed l-zeuch closed 2 years ago

l-zeuch commented 2 years ago

Firefox version: 78.14.0esr

Addon version: v1.4.2 (latest release as of now)

Steps to reproduce: Follow the steps provided in the README:

image of error

Other Solutions I tried:

Claudiohbsantos commented 2 years ago

Sorry about that, you are correct that the installatino doesn't work.

The extension is not corrupt, but firefox shows that (very unhelpful) message when attempting to install an unsigned extension. You can temporarily install the extension in debug mode by going to about:debugging. That's not very useful though because extensions loaded that way don't persist browser close/re-opens.

There seems to be a couple of ways to disable the signature check for add-on installation but I can't really recommend it since they seem like a lot of work for a bad hack.

I just cut a new release and am submitting it for Firefox approval one more time. According to them it could take a bit for it to be reviewed though

delays

Claudiohbsantos commented 2 years ago

I'm going to close this issue since there is nothing else I can do besides wait for review. Ill see if I can change the way the SVGs are loaded to avoid the need for manual reviews, but that's a bigger change that might not happen immediately. Thanks for the report!

l-zeuch commented 2 years ago

Thank you for your answer and the insight.

Really hope Mozilla reviews it ASAP, it's a super cool extension, thank you for your work!