material-extensions / material-icons-browser-extension

Browser Addon that enhances file browsers of version controls with material icons.
MIT License
511 stars 38 forks source link

Symlink and submodule icons won't show when items match a known extension #27

Closed kidonng closed 2 years ago

kidonng commented 2 years ago

Thanks for your efforts in resolving #3! Unfortunately when the items match a known extension:

image

(https://github.com/svartalf/rust-battery/tree/master/battery)

...the symlink and submodule icons won't show:

image

These lines should be hoisted (put in front of the languages matching code):

https://github.com/Claudiohbsantos/github-material-icons-extension/blob/f212d076ac119a027f117e9ab4eee5da528b74ef/src/main.js#L158-L159

Claudiohbsantos commented 2 years ago

:see_no_evil: Ok, once you put it like that it seems pretty obvious.

Thanks for including the solution. I'll add it in the next batch of changes.

Claudiohbsantos commented 2 years ago

chrome_qJysH7hYaD

Fix has been merged. Will be released with next changes soon