material-extensions / material-icons-browser-extension

Browser Addon that enhances file browsers of version controls with material icons.
MIT License
524 stars 39 forks source link

Preserve symlink and submodule icons #3

Closed kidonng closed 3 years ago

kidonng commented 3 years ago

Symlinked folders/files (including submodules) have a different icon to indicate their type, but this extension doesn't preserve it.

Without extension: image

With extension:

image

Test repo: https://github.com/lxqt/lxqt

Claudiohbsantos commented 3 years ago

That's a very good point. The VSCode extension doesn't seem to need any special handling of symlinks because there is another indicator in the explorer for such files/folders, but in this case it becomes undistinguishable.

I'll look into how to painlessly skip modifying these icons without having to change the upstream icon mappings

Claudiohbsantos commented 3 years ago

Submodules now show the "git" folder icon, and symlinks have a new custom icon. See image below for reference

chrome_744kL8oHOo

I'm closing this issue since this change should make it into the next release already. Thanks for opening it :)

kidonng commented 3 years ago

Awesome! Thanks for your work.