Design flickers on hard reload on GitHub

material-extensions / material-icons-browser-extension

Browser Addon that enhances file browsers of version controls with material icons.

MIT License

511 stars 38 forks source link

Design flickers on hard reload on GitHub #35

Closed shivapoudel closed 2 years ago

shivapoudel commented 2 years ago

If I tried to hard reload the repository page with cached cleared this kind of design flicker is happening and soon gets disappeared. @Claudiohbsantos can you investigate this I tried but couldn't figure out the culprit styling.

Claudiohbsantos commented 2 years ago

Hmmm.. Looks like we need to raise the number of icons that are handled synchronously on load. (see this part of the code) No idea what changed to make this necessary. I just pushed a change that I'm hoping will take care of this (it seems to do locally).

I'll hold on cutting a new commit while we wrap up the PR that is open. If that is not merged by next weekend I'll try to cut a version including this change so it goes live.

Thanks for the report!

Claudiohbsantos commented 2 years ago

I'm going to close this issue since I believe it is fixed by that commit. Feel free to mention me here if that turns out to not be fixed once this is released