material-extensions / material-icons-browser-extension

Browser Addon that enhances file browsers of version controls with material icons.
MIT License
511 stars 38 forks source link

Fix ESLint config #38

Closed csandman closed 2 years ago

csandman commented 2 years ago
Claudiohbsantos commented 2 years ago

Ops, I didn't realize you had this marked as Draft. This all looks good to me, thanks!

I fixed the conflicts and added a commit with 2 eslint warning fixes + some non-eslint things I found on the way.

Were you planning to add anything to this PR? I'm happy to merge it whenever you mark it ready for review

csandman commented 2 years ago

@Claudiohbsantos I had actually only drafted this PR to try and resolve the merge conflicts on GitHub (which I failed to do). I ended up making a new branch with all the final changes from a clean branch of the current master, but I also just pushed them here. So yeah, if you want to help me resolve the remaining conflicts then this branch is ready to go!

Claudiohbsantos commented 2 years ago

@csandman This looks great, thanks for taking care of all of the chores here! Yeah, I've been making a couple of changes to master so it was pretty easy to solve the conflicts since I remembered what I changed yesterday. I'm going to go ahead and merge this one in!