Closed csandman closed 2 years ago
Ops, I didn't realize you had this marked as Draft. This all looks good to me, thanks!
I fixed the conflicts and added a commit with 2 eslint warning fixes + some non-eslint things I found on the way.
Were you planning to add anything to this PR? I'm happy to merge it whenever you mark it ready for review
@Claudiohbsantos I had actually only drafted this PR to try and resolve the merge conflicts on GitHub (which I failed to do). I ended up making a new branch with all the final changes from a clean branch of the current master, but I also just pushed them here. So yeah, if you want to help me resolve the remaining conflicts then this branch is ready to go!
@csandman This looks great, thanks for taking care of all of the chores here! Yeah, I've been making a couple of changes to master so it was pretty easy to solve the conflicts since I remembered what I changed yesterday. I'm going to go ahead and merge this one in!
eslint-plugin-jsdoc
package, as this project uses JSDoc in multiple places with some invalid types.eslint-plugin-prettier
package in favor ofeslint-config-prettier
because they don't recommend using it.json-stable-stringify
packagehusky
andlint-staged
to format with prettier and lint the code in a pre-commit hook.@types/node-fetch
package as this is not a TS project and it serves no purpose(?)engines
fields in thepackage.json
to allow anything onnode@16
andnpm@8
because installing the dependencies is a pain otherwise. You can revert this if there is a specific reason for restricting them to these versions.