material-extensions / material-icons-browser-extension

Browser Addon that enhances file browsers of version controls with material icons.
MIT License
511 stars 38 forks source link

New permissions #39

Closed vastoa closed 2 years ago

vastoa commented 2 years ago

image

What for?

eugabrielsilva commented 2 years ago

Aparently the extension now also supports Azure DevOps and BitBucket too: https://github.com/Claudiohbsantos/github-material-icons-extension/pull/31, this requires a new set of permitted websites

Here is a screenshot of bitbucket image

Claudiohbsantos commented 2 years ago

Hey @pxladin ! Sorry about the scary notification. @eugabrielsilva is correct, the difference is that the previous version only required access to github.com while now we also do the same with azure, gitea and bitbucket.

You can see the manifest with the permissions from the previous version here and compare it with the current manifest permissions here.

If you click on "Show Details" on that notification you'll see the same list of websites: wCms8sI3V9

Also good to note is that with the upcoming #41 and the potential for an options page where we can set a couple of options for the extension (such as icon size, icon pack, etc...) there will probably be a couple of other changes in permissions in the next couple of versions. I'll try to keep these to a minimum but unfortunately I don't know a better way to notify users of why permissions are being changed.

vastoa commented 2 years ago

@Claudiohbsantos Ah, that makes sense. Thank you for clearing that up.