Closed zm-cttae closed 1 year ago
@zm-cttae I know I'm already a couple of months late but just wanted to bump this PR so you see that I saw it. I will need to dig a little bit into what these changes would mean so it'll take me a little bit to have a proper review but overall I'm not against these changes.
Cool. The big change is https://github.com/Claudiohbsantos/github-material-icons-extension/pull/49#discussion_r1045286088 which brings us closer to the upstream extension in behaviour
Add logic to try match contributed filenames/extensions to their icon using the existing icon map.Abstract the icon name logic in the build script.Test case:
processLanguageContribution
becauselang
isn't reassigned backconsole
will disappear inlanguage-map.json