material-extensions / material-icons-browser-extension

Browser Addon that enhances file browsers of version controls with material icons.
MIT License
499 stars 38 forks source link

Doesn't work work on nested routes on Arc Browser #53

Closed ChromeGG closed 1 year ago

ChromeGG commented 1 year ago

Hi, I noticed that this extension doesn't work on nested routes on Arc Browser (which is chromium based)

CleanShot 2023-02-02 at 20 49 41

I tested it on Brave and everything was fine.

The repo from the screen is here

Claudiohbsantos commented 1 year ago

Hey @ChromeGG . Thanks for opening up this issue.

To be very honest, this will likely not be addressed for a while, unless someone with Arc Browser access wants to diagnose and propose a PR that solves the problem. Arc still requires a waitlist on Mac and is not available on Windows so it is tricky to develop and test the extension on it (my main personal computer is currently running Windows).

I'll leave this open for a bit to see if anyone is interested in pursuing it though

pplmx commented 1 year ago

Chrome has the same issue.

Chrome version: 110.0.5481.178

pplmx commented 1 year ago
  1. Enter the nested dir
  2. back to the root dir
  3. cannot display correctly(It cannot refresh automatically, it works fine on the root dir after the refreshing manually)
  4. image

pplmx commented 1 year ago

It is also related to #55 and #47. After disable the new code view, it all works fine again.

csandman commented 1 year ago

I got Arc browser to take a look at this, and it appears to be working fine for me. I have not noticed any issues in nested routes (except for the new code view, which is broken on all browsers).

Claudiohbsantos commented 1 year ago

Thanks for the tests! The code view related things should be fixed on the next release. I'll close this issue since the first screen shot makes me believe this was actually about the code view (there's a lot of space between those columns for the legacy view). Feel free to reopen if you continue to see issues with Arc