.webmanifest file extension recognized in vscode theme but not in github

material-extensions / material-icons-browser-extension

Browser Addon that enhances file browsers of version controls with material icons.

MIT License

499 stars 38 forks source link

.webmanifest file extension recognized in vscode theme but not in github #54

Closed AdamRaichu closed 1 year ago

AdamRaichu commented 1 year ago

In my repo AdamRaichu/adamraichu.github.io I have a file manifest.webmanifest that I was messing around with. In vscode, it has the JSON file icon, but on GitHub (using the extension) it has the generic file icon.

Claudiohbsantos commented 1 year ago

Thanks for this report! I'll take a look at where the extension is pulling that relationship from. I have a feeling that the open mr related to language mapping might touch this already, but I'll have to check. I'll label this issue in case someone else wants to jump on it first since it'll likely be a little bit before I can focus on it.

PKief commented 1 year ago

Yes, the icon association of files ending with ".webmanifest" is based on the language mapping.

Claudiohbsantos commented 1 year ago

The issue seems to be resolved with the latest set of updates to language mapping. I expect this to be fixed on the next version that lands in the stores so I'll close this issue. Feel free to reopen if I'm wrong