search

material-extensions / material-icons-browser-extension

Browser Addon that enhances file browsers of version controls with material icons.
MIT License
499 stars 38 forks source link

Duplicated Icons when changing icon Packs on 1.8.0 #63

Closed Claudiohbsantos closed 1 year ago

Claudiohbsantos commented 1 year ago

Just recording that I've noticed a small bug with the version that I just released where changing icon packs results in duplicated icons until refresh: Screen Shot 2023-04-27 at 12 51 19 AM

Pretty sure this is just a side effect of some of the changes to the icon replacement logic we introduced in #56 . Overall I'd rather live with this for a bit than revert since a lot of people seem to be using the new code view.

@csandman just tagging you for visibility, I'm happy to take a stab at it .

andry81 commented 1 year ago

Just for instance, there is another icons extension and it works as expected: https://github.com/homerchen19/github-file-icons

csandman commented 1 year ago

Ah, that's my bad for not checking the icon packs! It was a pretty simple fix though, and I just submitted a PR!