search

material-extensions / material-icons-browser-extension

Browser Addon that enhances file browsers of version controls with material icons.
MIT License
499 stars 38 forks source link

Symlink icons are not preserved #75

Closed kidonng closed 1 week ago

kidonng commented 9 months ago

This has been fixed in #3, but is now a regression.

Example: https://github.com/lxqt/lxqt

Native:

image

With extension:

image
csandman commented 9 months ago

Weird, for me (on v1.8.6) they all appear to be working fine:

image

kidonng commented 9 months ago

Thanks for reminding me having some preview features enabled (this issue particularly could be due to "New Repository Overview").

I will check again with them disabled later.

csandman commented 9 months ago

Ah, yes I gave it a shot with that preview flag and have the same issue. Oh, and these are submodules btw.

Tbh, with that feature preview, there really isn't a good way to determine if a folder is a submodule anymore. The only distinguishing feature I can find on the icons is the SVG's actual path. Other than that, the aria-label attributes the icons had before are no longer included. It's probably worth waiting until this feature is made non-experimental before anything is done to try and fix it.