Dark/Light theme detection

material-extensions / material-icons-browser-extension

Browser Addon that enhances file browsers of version controls with material icons.

MIT License

511 stars 38 forks source link

Dark/Light theme detection #8

Closed Claudiohbsantos closed 3 years ago

Claudiohbsantos commented 3 years ago

Moving discussion from https://github.com/PKief/vscode-material-icon-theme/issues/1105 to here

shivapoudel commented 3 years ago

Fixed https://github.com/Claudiohbsantos/github-material-icons-extension/pull/7/commits/dec3b8827f23f906cbcdb98ecbb1022cc0109f01

Claudiohbsantos commented 3 years ago

Thanks! that's a great addition!

At some point it would be great to make this toggleable since I think the github profile settings override the browser preference, so there might be mismatch there. It's already an improvement over what we have though so it should probably come in a separate PR if we ever get to it

shivapoudel commented 3 years ago

@Claudiohbsantos We can close this as we now support this feature!