search

material-extensions / material-icons-browser-extension

Browser Addon that enhances file browsers of version controls with material icons.
MIT License
499 stars 38 forks source link

Allow users to specify custom domains #84

Closed jamiehaywood closed 1 week ago

jamiehaywood commented 3 months ago

I have an internally hosted GitLab at work, and I would like to be able to specify a custom domain to use the GitLab icon parser.

At first glance at the code, this will probably need a rethink about how URLs are associated to their providerConfigs - not sure how you would want to approach that?

I can give the feature a go if you think it would be worthwhile, sketch out my idea & raise a PR.

theoludwig commented 3 months ago

That would be a useful feature for specyfing Gitea domains as well. As gitea.com is specified in the default domains, it should be supported.

theoludwig commented 2 months ago

For reference, I tried to make it work with the minimal code changes as possible, and it only takes 3 lines of code to add our own custom domain (manually). Commit: https://github.com/theoludwig/github-material-icons-extension/commit/12d81470e671fb2397293f4ca555a5fb02150819

Of course, it would be better if it was not directly in the source code, hard coded, but rather a User config and also dynamic, so that users can add custom domains indefinitely. To implement this feature, the tasks could be:

mikeydevelops commented 1 week ago

This is possible now, #85 was merged in the fork and then the fork was merged here. You can close this now.

oliverjhyde commented 1 week ago

Do we know what the ETA on the extension being updated is now there's a 2.0.0 release? Or is that entirely in Mozilla/Googles control?

mikeydevelops commented 1 week ago

Latest version is 1.8.18, I do not know when it will release to browser stores, but I presume sometime by the end of the week.

oliverjhyde commented 1 week ago

Sorry yes, somehow ended up looking at kryota-dev/github-material-icons-extension

PKief commented 1 week ago

Yes, the release should happen as soon as possible. I'm working on this 😊

PKief commented 1 week ago

As #85 has been merged with https://github.com/material-extensions/material-icons-browser-extension/commit/e153f99d107d4aff5b80a3304bfbb153cd87e39b I'm going to close this issue now.