search

material-extensions / vscode-material-icon-theme

Available on the VSCode Marketplace
https://marketplace.visualstudio.com/items?itemName=PKief.material-icon-theme
MIT License
2.05k stars 630 forks source link

[Icon Request] Elixir extension .eex #1005

Open joaoeliandro opened 3 years ago

joaoeliandro commented 3 years ago

I can submit a PR, no problem, just a little guidance and feedback about the idea. 😄

PKief commented 3 years ago

I was wondering what the problem is with the existing icon? Why do you want to change the color? I'm just curious, don't know Elixir very well.

joaoeliandro commented 3 years ago

This icon is used with html.eex extensions, for example when we use the Pheonix framework. But the default icon is actually used only with .ex extension.

PKief commented 3 years ago

Alright, got it. Feel free to create a PR for it and I'll take a look.

joeljuca commented 3 years ago

EEx is not Phoenix-specific. I don't think it makes sense to put a Phoenix-like icon on an Elixir-wide feature.

joaoeliandro commented 3 years ago

The idea is to change the icon to html.eex extension specifically.

I was use Phoenix framework as example