material-extensions / vscode-material-icon-theme

Available on the VSCode Marketplace
https://marketplace.visualstudio.com/items?itemName=PKief.material-icon-theme
MIT License
2.1k stars 630 forks source link

[bug] Sentry icon not working #1088

Closed pgbradbury closed 2 years ago

pgbradbury commented 3 years ago

I have assigned the sentry icon to a few file types like this in my settings.json

    "sentry.properties": "Sentry",
    "sentry.client.config.js": "Sentry",
    "sentry.server.config.js": "Sentry",

along with several other icons. The rest work correctly, these files now show no icon.

PKief commented 3 years ago

Please apologize the late response, but what kind of settings.json are you using? The icon associations are only working in the user settings and not in the workspace settings. Hopefully this helps you :)

If you're wondering why the workspace settings are not working, there's already an issue (#208) for it.

pgbradbury commented 3 years ago

Hi @PKief , no problem, I am using the user settings. All other custom icon associations are working there, just the Sentry ones are not.

This is the block I have in the settings.json

"material-icon-theme.files.associations": {
    "package-lock.json": "Npm",
    "restql.yml": "Restql",
    "poetry.lock": "../../../icons/poetry",
    "pyproject.toml": "Python",
    "*.test.py": "Test-js",
    "*.steps.ts": "Test-ts",
    "docker-compose.init.yml": "Docker",
    "lint.report.json": "Eslint",
    "sentry.properties": "Sentry",
    "sentry.client.config.js": "Sentry",
    "sentry.server.config.js": "Sentry",
    "tsconfig.json": "Typescript-def",
    "next.config.js": "Vercel",
    "store.ts": "Redux-action",
    "*.reducer.ts": "Redux-reducer",
    "*.saga.ts": "Redux-store"
  },

Screenshot here:

image

pgbradbury commented 3 years ago

@PKief any ideas on this?

PKief commented 3 years ago

Hi @pgbradbury, sorry I can't reproduce it. I used the same settings as you pasted above and it's working. You could try to run the command "Material Icons: Restore Default Configuration" to delete the config. Make sure that you've copied your config somewhere else as a backup. As a last try you could try to reinstall the extension itself. As another solution you could also check if the sentry icon is existing in the icons directory of the Material Icons extensions folder and if you can open it e.g. with a web browser.

PKief commented 3 years ago

I also just removed the width and height properties of the SVG, maybe it helps something (commit 15c4ed9). Will update the extension soon with these changes.