material-extensions / vscode-material-icon-theme

Available on the VSCode Marketplace
https://marketplace.visualstudio.com/items?itemName=PKief.material-icon-theme
MIT License
1.94k stars 607 forks source link

[Icon Request] Ansible icon #1669

Open Igorgro opened 1 year ago

Igorgro commented 1 year ago

Icon Type

Folder Names

File Names

Graphic ideas Icon can be based on the official Ansible logo: https://upload.wikimedia.org/wikipedia/commons/2/24/Ansible_logo.svg

ghost commented 1 year ago

The ansible folder icon already exists, it's just not associated with those folder names. You can make roles and playbooks associated with it with the following steps.

  1. Open settings.json
  2. Create a new key called material-icon-theme.folders.associations and set it to an object.
  3. Inside material-icon-theme.folders.associations create a key called roles and set it to ansible.
  4. Then, do the same for playbooks. Create a key called playbooks and set it to ansible.

Done!

Screen Shot 2022-12-27 at 3 23 42 PM

There is no ansible file icon though, unfortunately.

Additional context: There are other YAML file extensions like .yaml and .yaml-tmlanguage besides *.yaml

Igorgro commented 1 year ago

@tj-commits wow! thanks for this information. But it is strange that this icon is not listed in the readme of this repository

PKief commented 1 year ago

@tj-commits wow! thanks for this information. But it is strange that this icon is not listed in the readme of this repository

There's a stupid reason why the icon is not listed in the readme. It's just because the preview in the readme always has these five columns to show all of the icons. To fill these five columns with icons we need an amount of icons which can be devided by five. And some time ago I decided that the ansible folder icon is part of these icons which can be skipped to get the number of icons divisible by 5😬

https://github.com/PKief/vscode-material-icon-theme/blob/6c385a34a9adb7489e65fb0611163ba7a8f27148/src/scripts/preview/index.ts#L35-L40

ghost commented 1 year ago

@Pkief you should change it in the next update

raymonds1987 commented 2 months ago

Any updates on this? The issue is for both folder icons and file icons, but there are still only folder icons implemented. I'd like to see Ansible icons for filetype ansible too