material-extensions / vscode-material-icon-theme

Available on the VSCode Marketplace
https://marketplace.visualstudio.com/items?itemName=PKief.material-icon-theme
MIT License
2.08k stars 627 forks source link

[Icon Request] Typescript_svelte, Javascript_svelte #1993

Open TheBlckbird opened 1 year ago

TheBlckbird commented 1 year ago

Icon Type

File Names

Graphic ideas

and the same for JS.

The icon should be the TS/JS icon but with the Svelte logo in a corner. Another idea was to change the color of the TS/JS icon and I think that it looks better than the other three examples. But I wanted to share them anyway.

Additional context Are there other frameworks using these naming conventions? Then would we need to create an icon pack.

suwermave commented 1 year ago

First one looks cool!

TheBlckbird commented 1 year ago

Here are the SVGs with the correct colors

mallowigi commented 1 year ago

Not in favor of the idea though. What's the relation of page.js to svelte

TheBlckbird commented 1 year ago

@mallowigi SvelteKit uses +page.ts and the other files for server side stuff or just scripts that belong to a specific route/layout

TheBlckbird commented 1 year ago

I’ll just create a PR. If this feature is really not wanted, we can just close it.

TheBlckbird commented 1 year ago

See #2009

Zerotask commented 1 year ago

To extend your list:

In addition to that, I noticed that svelte.config.js does show a Svelte icon, but svelte.config.ts just shows a regular TS icon.

TheBlckbird commented 1 year ago

Thanks, I will update it

TheBlckbird commented 1 year ago

In addition to that, I noticed that svelte.config.js does show a Svelte icon, but svelte.config.ts just shows a regular TS icon.

It seems like svelte doesn't support ts for the config file yet. github.com/sveltejs/kit/pull/4031

TheBlckbird commented 1 year ago

I don't think we should put the hooks in here as they are just too generic

vidhanio commented 1 year ago

I don't think we should put the hooks in here as they are just too generic

maybe a new icon pack for svelte?

TheBlckbird commented 1 year ago

I don't think we should put the hooks in here as they are just too generic

maybe a new icon pack for svelte?

done