material-extensions / vscode-material-icon-theme

Available on the VSCode Marketplace
https://marketplace.visualstudio.com/items?itemName=PKief.material-icon-theme
MIT License
1.95k stars 607 forks source link

File association to custom icons in `.vscode/extensions/icons` seems to no more work #2097

Open MohamedLamineAllal opened 9 months ago

MohamedLamineAllal commented 9 months ago

Describe the bug File association to custom icons in .vscode/extensions/icons seems to no more work

To Reproduce Steps to reproduce the behavior:

add icon to

.vscode/extensions/icons
  "material-icon-theme.files.associations": {
    "**.j2": "../../icons/red"
  },

doesn't work

  "material-icon-theme.languages.associations": {
    "ansible-jinja": "../../icons/red"
  }

Expected behavior

See the icons change. As the above does follow the doc.

Or set a custom folder path setting, like vscode-icons does and it works well.

Screenshots

Icons not changing

image

Folder structure

image

.vscode/settings,json

  "files.associations": {
    "ansible/**/*.yml": "ansible",
    "*.cnf": "ini",
    "*.cfg": "ini",
    "*.j2": "ansible-jinja"
  },

 "workbench.iconTheme": "material-icon-theme",
  "material-icon-theme.activeIconPack": "react_redux",

User settings

"workbench.iconTheme": "material-icon-theme",
  "material-icon-theme.activeIconPack": "none",
  "material-icon-theme.opacity": 0.7,
  "material-icon-theme.folders.theme": "none"

Computer information (please complete the following information):

illyrius666 commented 7 months ago

i have the same issue where using custom icons in the .vscode/extensions/icons folder doesnt work.

PKief commented 7 months ago

In which settings file did you put your icon definitions? It's important to mention, that you can only use the user settings for this feature, not the workspace settings

Omarov3000 commented 6 months ago

I have the same issue image

"material-icon-theme.files.associations": {
    "test.ts": "../../icons/t"
  }

image

Tested in workspace & user settings. Everything is updated to the latest version.

PKief commented 6 months ago

I have the same issue image

"material-icon-theme.files.associations": {
    "test.ts": "../../icons/t"
  }

image

Tested in workspace & user settings. Everything is updated to the latest version.

I just tried the exact same setting and it was working. Can you check the developer tools of your VS Code instance and look for error messages regarding this icon?

image

iscorporacion commented 5 months ago

The reality is that this does not work, the only solution was to copy my icons folder to the extensions folder of c:/users/your-user/.vscode-insider/icons, but it seems like an unacceptable solution to me, it works in workspace and user settings

zhaohuanyuu commented 3 months ago

I have the same issue image

"material-icon-theme.files.associations": {
    "test.ts": "../../icons/t"
  }

image Tested in workspace & user settings. Everything is updated to the latest version.

I just tried the exact same setting and it was working. Can you check the developer tools of your VS Code instance and look for error messages regarding this icon?

image

Same issue, It uses the root directory .vscode instead of the workspace

image

jamiehaywood commented 1 week ago

I think it's an issue with VSCode insiders