material-extensions / vscode-material-icon-theme

Available on the VSCode Marketplace
https://marketplace.visualstudio.com/items?itemName=PKief.material-icon-theme
MIT License
1.94k stars 608 forks source link

[Bug] "Problems parsing file icons file: End of file expected" with latest version of extension (4.34.0) #2244

Open Deckstar opened 4 months ago

Deckstar commented 4 months ago

Describe the bug The extension breaks for me with the latest version (v.4.34.0). VS Code displays an error message: "Problems parsing file icons file: End of file expected"

To Reproduce Steps to reproduce the behavior:

  1. Uninstall the extension
  2. Reinstall the latest version. Click "Set File Icon Theme" in extension page.
  3. You should see the error displayed as a snackbar. Meanwhile, the extension doesn't work and the file/folder icons don't change.

Expected behavior Extension should work as normally without errors.

Screenshots If applicable, add screenshots to help explain your problem. Screenshot 2024-03-05 at 4 50 19 PM

Computer information (please complete the following information):

Additional context I first noticed the issue when my custom icons in settings.json weren't working. Then I tried to select an icon pack, but VS Code would always set it to "None". So I reinstalled the extension, after which I got this error. Downgrading to 4.33 fixes the issue for me 🤷‍♂️

I recall that a while ago (~1 year ago?) I experienced the same issue, and that time the downgrading worked, too. I remember that time I manually fixed the issue by messing with some apparently deformed JSON in the extension (though I don't have time to look into it right now unfortunately, since I can't even remember where to find the extensions folder on my Mac). If it would be helpful, though, I could look into it later.

Other than that, thanks for the awesome extension that I've been using for many years! 🙂

Deckstar commented 1 week ago

Bump. Am I the only one facing this issue?