search

material-extensions / vscode-material-icon-theme

Available on the VSCode Marketplace
https://marketplace.visualstudio.com/items?itemName=PKief.material-icon-theme
MIT License
2.05k stars 629 forks source link

Updated android icon #2340

Closed okineadev closed 3 months ago

github-actions[bot] commented 4 months ago

Preview

Thank you for creating a pull request. This preview shows you how your changes will look on the different themes:

Generated Preview

You can find more information how to contribute in the contribution guidelines.

github-actions[bot] commented 4 months ago

Preview

Thank you for creating a pull request. This preview shows you how your changes will look on the different themes:

Generated Preview

You can find more information how to contribute in the contribution guidelines.

PKief commented 4 months ago

What's the problem with the old logo?

PKief commented 3 months ago

I don't see a reason for why we should change the Android logo. It looks good as it is right now. The new proposed icon is also not pixel perfect. This is why this PR is closed now.

okineadev commented 1 week ago

I don't see a reason for why we should change the Android logo. It looks good as it is right now. The new proposed icon is also not pixel perfect. This is why this PR is closed now.

@PKief, the old icon looks old, it's actually from 2007 (see https://www.androidpolice.com/every-android-bugdroid-ever)

Therefore, I want to update it to a modern look.

Regarding the pixel-perfect icon - I believe that it does not make any sense in this case and there is nothing to worry about it, and therefore I suggest to accept it.

PKief commented 1 week ago

If the icon is old but still has the best recognition value, then the old icon is still preferable.