material-extensions / vscode-material-icon-theme

Available on the VSCode Marketplace
https://marketplace.visualstudio.com/items?itemName=PKief.material-icon-theme
MIT License
1.94k stars 607 forks source link

Added bruno icon #2345

Closed okineadev closed 1 month ago

okineadev commented 1 month ago

Closes https://github.com/PKief/vscode-material-icon-theme/issues/2258

github-actions[bot] commented 1 month ago

Preview

Thank you for creating a pull request. This preview shows you how your changes will look on the different themes:

Generated Preview

You can find more information how to contribute in the contribution guidelines.

github-actions[bot] commented 1 month ago

Preview

Thank you for creating a pull request. This preview shows you how your changes will look on the different themes:

Generated Preview

You can find more information how to contribute in the contribution guidelines.

github-actions[bot] commented 1 month ago

Preview

Thank you for creating a pull request. This preview shows you how your changes will look on the different themes:

Generated Preview

You can find more information how to contribute in the contribution guidelines.

github-actions[bot] commented 1 month ago

Preview

Thank you for creating a pull request. This preview shows you how your changes will look on the different themes:

Generated Preview

You can find more information how to contribute in the contribution guidelines.

github-actions[bot] commented 1 month ago

Preview

Thank you for creating a pull request. This preview shows you how your changes will look on the different themes:

Generated Preview

You can find more information how to contribute in the contribution guidelines.

okineadev commented 1 month ago

Generated Preview

I think it will be better that way

okineadev commented 1 month ago

But you still need to paint the mouth black

PKief commented 1 month ago

Generated Preview

I think it will be better that way

yeah on a light theme background it does not look good, we should improve it a bit. Can't we make the mouth black as well?

okineadev commented 1 month ago

Generated Preview

I think it will be better that way

yeah on a light theme background it does not look good, we should improve it a bit. Can't we make the mouth black as well?

I don't understand Inkscape at all, I just figured out today how to add space around an image and that's it.

lucas-labs commented 1 month ago

Yeah, it looks really bad with a light background. Let me see what I can do with it =D

lucas-labs commented 1 month ago

What do you guys think about this one?

bruno_light.svg

<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 32 32"><polygon points="26 10 6 10 6 24 12 24 12 26 20 26 20 24 26 24 26 10" style="fill:#212121"/><path d="M27.89722,9.79443A6.85865,6.85865,0,0,0,23.54779,6.244,7.96754,7.96754,0,0,0,18,4H14A7.96754,7.96754,0,0,0,8.45221,6.244,6.85865,6.85865,0,0,0,4.10278,9.79443,19.91752,19.91752,0,0,0,2,18.702V20a4,4,0,0,0,4,4V16H8v6a4,4,0,0,0,4,4V24a2,2,0,0,1-2-2V20h2v2h2V20h4v2h2V20h2v2a2,2,0,0,1-2,2v2a4,4,0,0,0,4-4V16h2v8a4,4,0,0,0,4-4V18.702A19.91752,19.91752,0,0,0,27.89722,9.79443ZM10,14V12h2v2Zm4,4V16h4v2Zm8-4H20V12h2Z" style="fill:#ffab40"/><path d="M16,24a6.753,6.753,0,0,1-2,.99634V28a2,2,0,0,0,4,0V24.99634A6.75447,6.75447,0,0,1,16,24Z" style="fill:#f44336"/></svg>

image image

okineadev commented 1 month ago

What do you guys think about this one?

bruno_light.svg

<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 32 32"><polygon points="26 10 6 10 6 24 12 24 12 26 20 26 20 24 26 24 26 10" style="fill:#212121"/><path d="M27.89722,9.79443A6.85865,6.85865,0,0,0,23.54779,6.244,7.96754,7.96754,0,0,0,18,4H14A7.96754,7.96754,0,0,0,8.45221,6.244,6.85865,6.85865,0,0,0,4.10278,9.79443,19.91752,19.91752,0,0,0,2,18.702V20a4,4,0,0,0,4,4V16H8v6a4,4,0,0,0,4,4V24a2,2,0,0,1-2-2V20h2v2h2V20h4v2h2V20h2v2a2,2,0,0,1-2,2v2a4,4,0,0,0,4-4V16h2v8a4,4,0,0,0,4-4V18.702A19.91752,19.91752,0,0,0,27.89722,9.79443ZM10,14V12h2v2Zm4,4V16h4v2Zm8-4H20V12h2Z" style="fill:#ffab40"/><path d="M16,24a6.753,6.753,0,0,1-2,.99634V28a2,2,0,0,0,4,0V24.99634A6.75447,6.75447,0,0,1,16,24Z" style="fill:#f44336"/></svg>

image image

This is already really great

github-actions[bot] commented 1 month ago

Preview

Thank you for creating a pull request. This preview shows you how your changes will look on the different themes:

Generated Preview

You can find more information how to contribute in the contribution guidelines.

github-actions[bot] commented 1 month ago

Merge Successful

Thanks for your contribution! 🎉

The changes will be part of the upcoming update on the marketplace.

okineadev commented 1 month ago

👌