material-extensions / vscode-material-icon-theme

Available on the VSCode Marketplace
https://marketplace.visualstudio.com/items?itemName=PKief.material-icon-theme
MIT License
2.02k stars 619 forks source link

Add icon exclusion list for color check #2443

Closed okineadev closed 2 weeks ago

okineadev commented 1 month ago
image

We need to exclude some icons for testing, because it is better not to change their color

Here is a list of these icons:

PKief commented 1 month ago

Maybe the color check tool could scan for a specific attribute. If the attribute is present inside of the SVG file, then the colors of such a file are ignored.

okineadev commented 1 month ago

Maybe the color check tool could scan for a specific attribute. If the attribute is present inside of the SVG file, then the colors of such a file are ignored.

No, it would be better to add the exclude: key in the material-colors.yml configuration, and there already write a list of icons to exclude

Because these attributes will take up space and the purpose of svgo is to minimize svg The option with config will be the best

okineadev commented 2 weeks ago

Move this issue to https://github.com/PKief/svg-color-linter

PKief commented 2 weeks ago

I've moved it.