Open JonJamesDesign opened 5 years ago
Hi @JonJamesDesign, thank you for your kind feedback. I really like your idea, but the extensions API of VS Code doesn't support glob patterns for file icon associations at the moment. There's already an open issue in the official VS Code repository. Feel free to support it with a 👍
Is this still blocked? On the VS Code "files.associations" we can already specify wildcard at the end (e.g. "Jenkinsfile-*": "groovy"
).
I wish we could do the same with "material-icon-themes".
"material-icon-themes": {
"Jenkinsfile-*": "jenkins"
}
@tyron Yes, it's still blocked my missing API support.
Hi!
@PKief Is this still blocked?
Yes, unfortunately it's still blocked. The issue in the repository of VS Code is still open. Hopefully, it will be implemented someday. I'll keep you informed :)
@PKief ok, thanks!
@PKief Looks like this will not be supported by vscode - https://github.com/Microsoft/vscode/issues/12493#issuecomment-1084511097
Thanks for posting the issue! This is possible for dot segments of the filename in linear time without breaking the current implementation. I've put in a comment over there with a code sample.
reducers/*.js
can be supported already! (microsoft/vscode#136656)
To get it working, we need to put in new logic when we parse material-icon-theme.file.associations
.
The config key needs the <FOLDER>/
removed before processing the setting key & value..
then it should be added back to the key when appending that setting to the generated JSON.
I implemented filename globs in VS Code as a PR and they will assess soon™ - microsoft/vscode#174286
@zm-cttae thanks, that looks awesome :) Hopefully the VS Code team will take a look at it and include it to the API. Would solve lots of issues here.
@zm-cttae sorry for bothering you, have any updates? And am I correctly got, that this issue will allow features like that https://github.com/PKief/vscode-material-icon-theme/issues/1985 ? For *_test.ts
patterns or like that.
The last work done is microsoft/vscode#177650 I believe Martin is busy with Webpack and theming work atm though
I am also busy setting up VSCE Toolroom migrations.. we might find time for it in the summer 🙂
What I didn't realise is that Backlog =
"I am coming back to this 3 months later when my other large tickets get tested and land in production"
That gives me plenty of time to throw it together myself, I'll get on it soon :)
Loosely related on Stack Overflow: How can I associate an icon to a file in a specific path in VS Code with the Material Icon Theme Extension?
Any update on this issue?
Any update on this issue?
Sadly vscode still lacks support for glob/regex assignments (microsoft/vscode#174286)
This icon set is awesome; thanks for all the hard work so far, it's fantastic.
Further to the great work you've already done, it would be cool if I could set all files within a folder to use a certain icon; e.g:
Keep up the good work.