material-extensions / vscode-material-icon-theme

Available on the VSCode Marketplace
https://marketplace.visualstudio.com/items?itemName=PKief.material-icon-theme
MIT License
2.02k stars 620 forks source link

[Icon Request] .svg #400

Closed service-paradis closed 5 years ago

service-paradis commented 5 years ago

Right now, SVG files have the image icon. It would be great to have a specific icon for this file type (https://materialdesignicons.com/icon/svg).

smokes commented 5 years ago

I agree, this is a great idea. image

PKief commented 5 years ago

@service-paradis I already thought about this but I was not so happy about the proposed icon of materialdesignicons.com. I'm still not sure about it and was wondering if it looks intuitive for an SVG file. As shown in @smokes comment the icon looks like a sun 🌞

PKief commented 5 years ago

But I will evaluate if I find a proper icon for SVG files 😉

s0kil commented 5 years ago

It would be great to represent the vector nature of svg, everything is a line. Here is an idea: v-19-512

smokes commented 5 years ago

The "sun" has been the official svg logo for years https://www.w3.org/2009/08/svg-logos.html

PKief commented 5 years ago

Oops, I didn't really know that yet. I haven't seen the logo so often yet 🙈. Then the logo would actually fit well. I'll take a look, thank you! 😃

s0kil commented 5 years ago

Indeed, since the "sun" has been the logo for years, we do not want to create a new mental model.

mallowigi commented 5 years ago

If you ask me this icon by MFizz is way better https://raw.githubusercontent.com/file-icons/MFixx/master/svg/svg.svg?sanitize=true

s0kil commented 5 years ago

There is no reason to have "SVG" inside the logo, it's self-explanatory.

mallowigi commented 5 years ago

No it's not, anyone not familiar with the original logo would get confused as to why it is a sun.

Also it's here https://www.w3.org/2009/08/svg-logos.html

PKief commented 5 years ago

I've added the svg icon to the theme and it will look like this:

svg file icon

As you can see, we now also have a folder icon (related issue #358).

Thank you for your ideas!