[Icon Request] Angular page

material-extensions / vscode-material-icon-theme

Available on the VSCode Marketplace

https://marketplace.visualstudio.com/items?itemName=PKief.material-icon-theme

MIT License

2.06k stars 631 forks source link

[Icon Request] Angular page #504

Open clodbrasilino opened 5 years ago

clodbrasilino commented 5 years ago

Please use another color and put an angular page icon.

files with .page.ts extension.

Thanks!

PKief commented 5 years ago

Could you please explain to me what an Angular page is? I think it's not part of the official Angular components (like "component", "module" or "pipe").

Akxe commented 5 years ago

@PKief This does not seem to be any convention of Angular.

Do use conventional type names including .service, .component, .pipe, .module, and .directive. Invent additional type names if you must but take care not to create too many.

@clodbrasilino Unless the .page.ts file is used in some bigger project it will not be added.

clodbrasilino commented 5 years ago

I’m sorry guys, it’s not angular related. The .page.ts extension is from the Ionic Framework.

Do this plugin support icons for Ionic Framework?

PKief commented 5 years ago

This extension supports the following file names for ionic

ionic.config.json
.io-config.json

Are there some file extensions or file names missing for ionic? If there'd be more than *.page I could imagine to create some additional icons, same as for the angular file names.

clodbrasilino commented 5 years ago

@PKief until now that's the only filetype extension I'm missing.

It's just an Ionic Framework convention the extension .page.ts. Maybe designing this icon would not be cool? Since we can use any name, just the .ts extension that must show up, maybe it's not a good idea to put an icon on it. But the Ionic CLI generates this extension by default.

Akxe commented 5 years ago

@coldrasilino what is it for?

clodbrasilino commented 5 years ago

It's where you put TypeScript code for the pages you build in Ionic (there's a html, a Sass and a TS angular component).

Akxe commented 5 years ago

Is it a mix of the 3? Is there a link to docs with syntax?

clodbrasilino commented 5 years ago

The docs don't explain it clearly. What we have is:

An created Ionic Page (using Angular framework, through Ionic CLI) is composed of 5 files:

A .page.html file having HTML description of the page; (HTML icon here)
A .page.scss file containing SASS declarations; (SASS icon here)
A .module.ts file containing Angular module description; (Angular red icon here)
A .page.spec.ts file containing tests; (blue Erlenmeyer icon here)
A .page.ts file containing Angular component code. (blue TypeScript icon here)

I thought that maybe the last one should have a more friendly icon (maybe related to Ionic)?