search

material-foundation / arc-tslint

tslint linter for phabricator's arc command line tool
Apache License 2.0
7 stars 3 forks source link

missing warning #3

Open mbakker96 opened 7 years ago

mbakker96 commented 7 years ago

Hi,

I miss the warning for unused imports. 

$ npm run lint

> App@3.0.0 lint /Volumes/Projects/mobile
> ionic-app-scripts lint

[16:25:26]  ionic-app-scripts 2.1.4
[16:25:26]  lint started ...
[16:25:30]  tslint: src/components/flex-calendar/flex-calendar.ts, line: 1
            'OnChanges' is declared but never used.

       L1:  import {Component, OnChanges, OnDestroy, OnInit, SimpleChanges, ViewChild, ChangeDetectorRef, Input} from "@
       L2:  import {animate, state, style, transition, trigger} from "@angular/animations";

[16:25:30]  tslint: src/components/flex-calendar/flex-calendar.ts, line: 1
            'SimpleChanges' is declared but never used.

       L1:  import {Component, OnChanges, OnDestroy, OnInit, SimpleChanges, ViewChild, ChangeDetectorRef, Input} from "@
       L2:  import {animate, state, style, transition, trigger} from "@angular/animations";

[16:25:30]  lint finished in 3.96 s

 $ arc lint --everything
 OKAY  No lint warnings.

tslint.json:

{
  "rules": {
    "no-duplicate-variable": true,
    "no-unused-variable": true
  },
  "rulesDirectory": [
    "node_modules/tslint-eslint-rules/dist/rules"
  ]
}

.arclint:

{
  "linters": {
    "ts": {
      "type": "tslint",
       "include": "(src/.*\\.(ts)$)"
    }
  }
}
karan-kang commented 6 years ago

Same issue, running tslint manually shows warning, but it passed without any warnings with arc-tslint.