search

material-foundation / flutter-packages

A collection of useful Material Design packages
https://pub.dev/publishers/material.io
Apache License 2.0
841 stars 159 forks source link

Dynamic ColorScheme does not support new color tokens #591

Closed emmaxCreative closed 5 months ago

emmaxCreative commented 6 months ago

Package

dynamic_color

Existing issue?

What happened?

Expected vs actual result:

Expected result: dynamic colorscheme should support the new color tokens: for example surfaceContainerHigh etc

Actual result: All components of flutter that probably use the new tokens under the hood use a fallback color which results in an UI where you can se no different shades from different levels of containers. For example a card will have the same color as the scaffold background.

Steps to reproduce:

  1. install Flutter 3.22.1
  2. try to use dynamic theme

Relevant log output

Flutter (Channel stable, 3.22.1, on Microsoft Windows [Version 10.0.19045.4412], locale de-DE)
    • Flutter version 3.22.1 on channel stable at C:\flutter               
    • Upstream repository https://github.com/flutter/flutter.git           
    • Framework revision a14f74ff3a (6 days ago), 2024-05-22 11:08:21 -0500
    • Engine revision 55eae6864b                                           
    • Dart version 3.4.1                                                   
    • DevTools version 2.34.3
Henry-Hiles commented 5 months ago

I'm not sure if you have permission but this needs the "p: dynamic_color" label.

tmaihoff commented 5 months ago

Running into the same issue after upgrading to Flutter 3.22. Do you we have a timeline on this?

purofle commented 5 months ago

Same problem on Flutter 3.22

guidezpl commented 5 months ago

Closing as dupe of #582