material-foundation / material-color-utilities

Color libraries for Material You
Apache License 2.0
1.57k stars 134 forks source link

Build error from GCC #120

Closed envia closed 9 months ago

envia commented 9 months ago

When I tried to build Chromium, which uses material-color-utilities, using GCC 12 on Linux, I saw the following error:

FAILED: obj/third_party/material_color_utilities/material_color_utilities/tones.o 
g++ -MMD -MF obj/third_party/material_color_utilities/material_color_utilities/tones.o.d -DDCHECK_ALWAYS_ON=1 -DUSE_UDEV -DUSE_AURA=1 -DUSE_GLIB=1 -DUSE_OZONE=1 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FORTIFY_SOURCE=2 -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -DCR_SYSROOT_KEY=20230611T210420Z-2 -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -I../.. -Igen -I../../third_party/material_color_utilities/src -I../../third_party/abseil-cpp -Wall -Wno-unused-local-typedefs -Wno-maybe-uninitialized -Wno-deprecated-declarations -Wno-comments -Wno-packed-not-aligned -Wno-missing-field-initializers -Wno-unused-parameter -Wno-psabi -fno-ident -fno-strict-aliasing -fstack-protector -funwind-tables -fPIC -pipe -pthread -m64 -msse3 -Wno-builtin-macro-redefined -D__DATE__= -D__TIME__= -D__TIMESTAMP__= -O2 -fdata-sections -ffunction-sections -fno-omit-frame-pointer -g0 -fvisibility=hidden -Wno-narrowing -Wno-class-memaccess -std=gnu++2a -fno-exceptions -fno-rtti --sysroot=../../build/linux/debian_bullseye_amd64-sysroot -fvisibility-inlines-hidden -c ../../third_party/material_color_utilities/src/cpp/palettes/tones.cc -o obj/third_party/material_color_utilities/material_color_utilities/tones.o
../../third_party/material_color_utilities/src/cpp/palettes/tones.cc: In member function ‘material_color_utilities::Hct material_color_utilities::TonalPalette::createKeyColor(double, double)’:
../../third_party/material_color_utilities/src/cpp/palettes/tones.cc:70:9: error: ‘round’ was not declared in this scope
   70 |     if (round(chroma) == round(smallest_delta_hct.get_chroma())) {
      |         ^~~~~

I think including <cmath> to cpp/palettes/tones.cc can fix the error.

envia commented 9 months ago

I am closing this issue, as it a duplication of #108. I hope it is fixed soon.