search

material-foundation / material-color-utilities

Color libraries for Material You
Apache License 2.0
1.67k stars 144 forks source link

Use with latest Node.JS does NOT work because imports and exports do not follow ES6 modules rules, need file extension on import path. #68

Closed edgarlcs closed 1 year ago

edgarlcs commented 1 year ago

Hello I tried to use this module with Next.JS and it was returning the 'ERR_MODULE_NOT_FOUND' when trying to use it. To fix the issue I added the ".js" extension to all the exports and imports on all files.

WillsterJohnson commented 1 year ago

The library is completely unusable. This has been known for 7 months #35 I've submitted a PR which fixes this #61

AllanPinheiroDeLima commented 1 year ago

The library is completely unusable. This has been known for 7 months #35 I've submitted a PR which fixes this #61

Can't we fork this lib and apply this correction ? In JS it is pretty hard to make it work correctly as of now

Edit: I've seen you mentioned those forks at #61 but, for any reason, my fault or otherwise, I can't find them. Can you point me to a link of those forks so I can make it work ?

Thank you!

WillsterJohnson commented 1 year ago

@AllanPinheiroDeLima sure, the fork is mentioned in this comment https://github.com/material-foundation/material-color-utilities/issues/35#issuecomment-1214133323

guidezpl commented 1 year ago

This will be fixed in the next release, closing