search

material-foundation / material-color-utilities

Color libraries for Material You
Apache License 2.0
1.67k stars 144 forks source link

Initial Kotlin Multiplatform Support #76

Open DatL4g opened 1 year ago

DatL4g commented 1 year ago

This adds a Kotlin Multiplatform library people asked for months.

Closes #49 and closes #54

May require more improvements, however it's current state is at least the same state as the java (+ further methods e.g. create Theme from Image on Android and JVM).

I know this repo normally doesn't accept PRs currently, however I think it's better to merge and add this now, as it's more useful to maintain this than improving the java library

google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

mon-jai commented 1 year ago

IIRC Google doesn't accept pull requests to this repo.

DatL4g commented 1 year ago

IIRC Google doesn't accept pull requests to this repo.

@mon-jai read description

danielesegato commented 1 year ago

@DATL4G if you want them to consider your pull request you need to sign the CLA as per https://github.com/material-foundation/material-color-utilities/pull/76#issuecomment-1428784962 otherwise I doubt they'll even check the submission

DatL4g commented 1 year ago

@danielesegato I did when I opened the PR it just doesn't update the status here, but they know it's signed The PR needs a rebase anyway, if they consider a merge I'm going to do so