material-foundation / material-color-utilities

Color libraries for Material You
Apache License 2.0
1.57k stars 134 forks source link

Fixing Material Foundation's TypeScript Color Utilities Library (again) #81

Closed WillsterJohnson closed 1 year ago

WillsterJohnson commented 1 year ago

Fixes #79

TODO list;

WillsterJohnson commented 1 year ago

Hello again. I'm back, and very upset that I (a 20-year old Uni student) have to come along yet again to fix the glaringly obvious bugs in code written by the world-class engineers at Google. I don't deserve to write code anywhere close to anything you write, much less be the one to come by and fix the issues in your code. You work at Google for #@$& sake folks, how am I fixing your code?

See you all in approximately 500 days when this issue is resolved.

Best, Willster.

rodydavis commented 1 year ago

Thank you for the change, there is some context for why we had this in the package.json but due to changes in how we publish it was no longer needed.

This comment is incredibly rude and against our code of conduct, and keep in mind all comments made on open source repos are available forever.

In the future please comment with respect and constructive feedback. These repos require work to open source and get working properly.

WillsterJohnson commented 1 year ago

My apologies for my rudeness. I hope you can understand the frustration I feel though, as the Material Design System is something I find to be as close to perfection as possible, and yet using it is blocked by simple issues like this. My frustration is not meant to be directed at any of your team, just generally at Google due to their long-standing pattern of "make something amazing then under-support it's progression". I am very grateful for the work done by the material foundation, especially for open sourcing this library and continuing to support fixes and improvments.

rodydavis commented 1 year ago

Latest code is pushed to main, working on publishing to npm