search

material-foundation / material-remixer-android

Remixer for Android. Live adjustment of app variables.
Apache License 2.0
774 stars 54 forks source link

Fix format strings that were broken by data type change #106

Closed miguelandres closed 7 years ago

miguelandres commented 7 years ago

Whoops

pingpongboss commented 7 years ago

Oh, I see https://github.com/material-foundation/material-remixer-android/pull/108 now

miguelandres commented 7 years ago

Interestingly, the tests are there for the failure with an IllegalArgumentException.... Which is what I'm expecting, turns out that this format exception is a subclass of IllegalArgumentException so they were passing for exactly the right/wrong reason:

The format string was illegal while trying to create an error message for an illegal argument exception.

It's such an edge case that I don't think it's worth it to invest much more time in it, nor do I expect to change data types again.... so....