search

material-foundation / material-remixer-android

Remixer for Android. Live adjustment of app variables.
Apache License 2.0
774 stars 54 forks source link

Bump SDK versions #144

Closed jonathan-caryl closed 7 years ago

jonathan-caryl commented 7 years ago

And extract more version numbers in to the project root, to make them easier to update in the future

miguelandres commented 7 years ago

This breaks unit tests, can you debug the issue locally and update your pr?

codecov-io commented 7 years ago

Codecov Report

Merging #144 into develop will increase coverage by 0.02%. The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #144      +/-   ##
=============================================
+ Coverage      56.25%   56.28%   +0.02%     
  Complexity       233      233              
=============================================
  Files             54       54              
  Lines           1527     1528       +1     
  Branches         150      150              
=============================================
+ Hits             859      860       +1     
  Misses           612      612              
  Partials          56       56
Impacted Files Coverage Δ Complexity Δ
...braries/remixer/ui/widget/number/FloatSeekBar.java 71.42% <ø> (ø) 0 <0> (ø) :arrow_down:
...ies/remixer/ui/widget/ColorListVariableWidget.java 57.4% <100%> (+0.8%) 0 <0> (ø) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1b13f26...646f0f8. Read the comment docs.

jonathan-caryl commented 7 years ago

@miguelandres I've tweaked this to not update the gradle version, as that seems to be what breaks the tests. I've found various 'fixes' online, none of which seemed to work in this case, so I figure it's best to change the gradle version in another PR when I've figured out exactly what's going on.