material-foundation / material-remixer-android

Remixer for Android. Live adjustment of app variables.
Apache License 2.0
774 stars 54 forks source link

Mark Variable/Trigger constructors private #82

Closed miguelandres closed 8 years ago

miguelandres commented 8 years ago

These constructors should not be used directly, this makes the use of Builders mandatory.

These constructors have far too many parameters, they are hard to use and error-prone, Builders make errors more obvious.

codecov-io commented 8 years ago

Current coverage is 66.15% (diff: 100%)

Merging #82 into develop will increase coverage by 0.37%

@@            develop        #82   diff @@
==========================================
  Files            44         44          
  Lines          1166       1164     -2   
  Methods           0          0          
  Messages          0          0          
  Branches        152        152          
==========================================
+ Hits            767        770     +3   
+ Misses          339        334     -5   
  Partials         60         60          

Powered by Codecov. Last update 840e9b6...51c8b41