search

material-foundation / material-roboto-font-loader-ios

Apache License 2.0
23 stars 18 forks source link

Remove unneeded fonts and unhint others. #17

Closed dmaclach closed 5 years ago

dmaclach commented 5 years ago

Remove Black, BlackItalic, Thin and ThinItalic since we aren't using them (save ~360K). Change all other fonts to unhinted versions and save another ~100K.

romoore commented 5 years ago

@codeman7 , @dmaclach How can we be sure that third parties aren't using Black, BlackItalic, Thin, and ThinItalic? I'm not familiar with font "unhinting", but it seems non-destructive.

dmaclach commented 5 years ago

Honestly I can't, but at the same time I would consider it basically the same as using a private API. The argument about breaking "third parties" is a slippery slope that can lock you into no improvements at all.

I'm not a big fan of this API at all honestly. Tying all of the font faces together into a single "loader" class means that I get to pay for all of the font faces even if I just want to use one.

Cheers, Dave

On Wed, Apr 10, 2019 at 7:21 AM Robert Moore notifications@github.com wrote:

@codeman7 https://github.com/codeman7 , @dmaclach https://github.com/dmaclach How can we be sure that third parties aren't using Black, BlackItalic, Thin, and ThinItalic? I'm not familiar with font "unhinting", but it seems non-destructive.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/material-foundation/material-roboto-font-loader-ios/pull/17#issuecomment-481711532, or mute the thread https://github.com/notifications/unsubscribe-auth/AATiybLfcxtYSWaUB5i0FeLk3ng0909Uks5vffNlgaJpZM4clcLe .