search

material-foundation / material-roboto-font-loader-ios

Apache License 2.0
23 stars 18 forks source link

MDFRobotoFontLoader+MDCTypographyAdditions.h assumes CocoaPods #6

Closed Arcank closed 7 years ago

Arcank commented 7 years ago

MDFRobotoFontLoader+MDCTypographyAdditions.h assumes CocoaPods

https://github.com/material-foundation/material-roboto-font-loader-ios/blob/stable/src/MDCTypographyAdditions/MDFRobotoFontLoader%2BMDCTypographyAdditions.h#L19 This is an issue when not using CocoaPods, as MaterialTypography.h is usually in .../components/Typography/MaterialTypography.h.

Arcank commented 7 years ago

Hmm, maybe I see what's going on.

  1. I uploaded a PR on stable to fix (#7).
  2. I realized I did a PR on stable instead of develop, so I uploaded a PR on develop (#8) and deleted the PR on stable (#7).
  3. You merged #8 (to develop), then merged stable to develop (cb0a347c8860bef7ee33d888de3e7e933eecc554), then released 1.1.2.

Step 3 undid #8 on develop and in the release though :)

randallli commented 7 years ago

fixed by https://github.com/material-foundation/material-roboto-font-loader-ios/pull/8

randallli commented 7 years ago

Looks like if I add args to pod lib lint --use-libraries it passes.