search

material-foundation / material-theme-builder

Visualize dynamic color and create a custom Material Theme.
https://material-foundation.github.io/material-theme-builder/
Apache License 2.0
363 stars 28 forks source link

Latest Material Theme Builder update for Figma broke the plugin #104

Closed LPirro closed 1 year ago

LPirro commented 1 year ago

Hello,

As some people reported on the Official Page on Figma the plugin is broken after the last update. I'm not being able to use it, swapping light/dark for example, does not work properly, and also the UI looks really weird.

Just wanted to open an issue to let you know. Please help the community with this because, in its current state, the plugin is not usable anymore.

For any additional information that could help investigate this just let me know.

Thank you.

margeeta commented 1 year ago

Hi, thank you filing the issue!

The latest update was needed to fix some long standing bugs like correcting colors from being overwritten when opening the plugin along with addressing performance. This meant updating some token syntax along the way.

That said, light/dark swap should work still even with previous themes (unless it's a very old theme). It may take a second or two to actually swap them.

You may have to generate a new theme to get key colors to register and show up, without doing so will register as No Core Colors Found.

Do you mind providing any screenshots? We will be doing some follow updates to address UI bugs along with troubleshooting notes.

LPirro commented 1 year ago

@margeeta Sure. It seems that something is broken with the tokens. I also tried with a brand new project. It just doesn't change the colours for components from a library (like Material Design Kit). Components like Buttons, Navbars, Chips, etc. Screenshot 2023-01-20 at 09 47 00

It's really sad because I cannot design anymore like this :(

margeeta commented 1 year ago

We will be making a design kit update to align tokens. I did have success swapping components though, but it did take a couple tries with Swap.

LPirro commented 1 year ago

@margeeta Thanks for addressing this. If I can help somehow just let me know.

Also, more people are commenting on Figma Page that they have issues with the plugin: https://www.figma.com/community/plugin/1034969338659738588/Material-Theme-Builder

LPirro commented 1 year ago

@margeeta any update on this?

margeeta commented 1 year ago

Design kit to be updated this week to reflect latest color updates!