search

material-foundation / material-theme-builder

Visualize dynamic color and create a custom Material Theme.
https://material-foundation.github.io/material-theme-builder/
Apache License 2.0
363 stars 28 forks source link

Update theme colors only if I add a new theme #106

Closed lsalehar closed 1 year ago

lsalehar commented 1 year ago

It's really annoying that the plugin changes colors of the theme when I change the theme from dynamic to custom and everytime I open the plugin.

Please:

  1. Change existing theme only when I change the color manually
  2. Don't change existing theme if I switch from dynamic to custom (display currently defined colors) - It's great to customize a theme from a defined source color that was generated dynamically
  3. Keep the colors if I add a theme
  4. Change colors only if I switch themes.
margeeta commented 1 year ago

Thanks @lsalehar, we have to reset between the two states for plugin performance currently.

But, in your workflow, would you prefer customization and dynamic together or to remain separate, as it is now?

lsalehar commented 1 year ago

Hi @margeeta, thank you for the reply. Can you please elaborate on your question a bit further? I'm afraid I don't understand exactly what you're asking me.

margeeta commented 1 year ago

Now should only update when color has been changed, and applied.

We sadly can't keep the dynamically generated theme between the two states, but have some planned future work to resolve this! But primary in custom does act in the same way source color does in dynamic, if you'd like to generate an entire scheme from one source color.