search

material-foundation / material-theme-builder

Visualize dynamic color and create a custom Material Theme.
https://material-foundation.github.io/material-theme-builder/
Apache License 2.0
362 stars 28 forks source link

Secondary colors don't change on the design files while the color on plugin interface changed. #119

Closed Aliiiceee closed 6 months ago

Aliiiceee commented 1 year ago

Secondary colors don't change on the design files while the color on the material theme builder plugin interface changed.

lydia680 commented 1 year ago

Same here

margeeta commented 1 year ago

Hi, Can you please provide more info and steps, along with screenshots? Thank you.

lucaben commented 1 year ago

I am also having issues. Primary colour updated as custom colour, secondary and tertiary are automatically modified, but not all changes are reflected. In the screenshot below, you can notice the background colour of elevated buttons and the component's header section, are still in the original hue. Surface and state layer colours (e.g. state layer-light-primary) have not been updated, and I have to do this manually if I want them to reflect the primary colour that I've chosen.

lucaben commented 1 year ago
Screenshot 2023-03-28 at 18 20 41
margeeta commented 1 year ago

Hi, Design kit will be updated to reflect latest color updates soon. Make sure to switch on state-layers in settings, this will make the theme builder update state-layers used in the kit. This is off by default due to the amount of state-layer styles. ![Uploading settings_statelayers.png…]()

lucaben commented 1 year ago

Thanks @margeeta, that's very helpful. Can you share any more detail on the coming updates that you've mentioned (what, when)?

margeeta commented 1 year ago

The M3 color system just updated Surfaces and released new fixed accent roles. Surfaces are no longer computed as overlays and now based on tonal values! More here: https://m3.material.io/styles/color/the-color-system/color-roles#0abbf8b7-61e1-49ee-9f97-4967beb1e4fe

Fixed accents are a new color group that stays the same across light and dark theme. Fixed accent: https://m3.material.io/styles/color/the-color-system/color-roles#232e7275-6ef2-4b93-afa6-c5f76e378ced

lucaben commented 1 year ago

Thanks @margeeta. Would you recommend to wait a few days for the changes to the surface colours to be reflected in Figma, or can it also be done later? It looks to me like there isn't a distinction anymore between neutral grey colours and surface colours, which would then simplify things a bit. Did I get it right?