material-foundation / material-theme-builder

Visualize dynamic color and create a custom Material Theme.
https://material-foundation.github.io/material-theme-builder/
Apache License 2.0
362 stars 28 forks source link

Doesn't generate surface container colors #144

Closed Garaba-PureCommit closed 1 year ago

Garaba-PureCommit commented 1 year ago

Plugin doesn't generate surface container colors described here https://m3.material.io/styles/color/the-color-system/color-roles#8edc07d2-1579-4891-819f-b3a182704b19 How can I generate this colors for custom theme ?

margeeta commented 1 year ago

Hi, Expect a new update next week that will include the new surface roles and fixed accents! :)

palexdev commented 1 year ago

@margeeta 2 weeks passed, but this seems to still be an issue https://m3.material.io/theme-builder#/custom doesn't generate the new surface tokens Is it still an older version?

margeeta commented 1 year ago

@palexdev Yes, Figma has been updated, along with design kit. Web version will be updated soon!

RequestPrivacy commented 1 year ago

Any estimate on the update of the web version?

kolyneh commented 1 year ago

Hi, can you check this, Figma and Web doesn't export surface container colors for Android Views, Compose, Flutter. It's only working for Json.

qyzhaojinxi commented 1 year ago

hi, surface container colors is still missing for android xml

VitaliyBelyaev commented 11 months ago

Hi! I also faced the problem that Figma Material Theme Builder Plugin doesn't add surface-container colors in xml for Android when exporting. In Figma those colors exist, also if exported as .json file surface-container colors exist there.

As workaround, I create python script that generates colors.xml and light/dark themes.xml from .json theme file exported from Figma plugin. Hope it helps someone!

qyzhaojinxi commented 11 months ago

@VitaliyBelyaev thanks, I will try it.

qyzhaojinxi commented 11 months ago

the text color on surface container is still missing. For example menu text color is black dark mode.