search

material-foundation / material-theme-builder

Visualize dynamic color and create a custom Material Theme.
https://material-foundation.github.io/material-theme-builder/
Apache License 2.0
419 stars 30 forks source link

Background colors are either bugged or soon to be deprecated? #148

Closed PrattiDev closed 1 year ago

PrattiDev commented 1 year ago

Describe the bug When remapping surface tokens, I've noticed that dark mode background is not pointing to the correct color, as it clashes with the new surface-container-low.

To Reproduce Steps to reproduce the behavior:

  1. Use background.
  2. Have an app bar on your mocks, which uses surface-container-low.
  3. Apply dark mode.
  4. See that they're the same shade, whereas surface seems to work much better for backgrounds.

Expected behavior background would be much darker, as it's supposed to be below everything else.

Screenshots bug-report-background-color

margeeta commented 1 year ago

Yes, we are encouraging everyone to move to the new tonal surfaces. Background is essentially replaced by surface. https://material.io/blog/tone-based-surface-color-m3 Not a bug :)

PrattiDev commented 1 year ago

Yes, we are encouraging everyone to move to the new tonal surfaces. Background is essentially replaced by surface. https://material.io/blog/tone-based-surface-color-m3 Not a bug :)

The post never mentioned background which is why I was confused. 🙏 But thank you!