search

material-foundation / material-theme-builder

Visualize dynamic color and create a custom Material Theme.
https://material-foundation.github.io/material-theme-builder/
Apache License 2.0
364 stars 28 forks source link

Add image selector to web version #15

Closed FluorescentHallucinogen closed 2 years ago

FluorescentHallucinogen commented 2 years ago

It would be really nice to have the image selector in web version like in Figma plugin:

material-theme-builder

FluorescentHallucinogen commented 2 years ago

Oh, I absolutely didn't notice the "Add your wallpaper" button in the bottom right corner! 🙈

@rodydavis What about moving it to the rest UI elements on the left side to make it more visible?

screenshot

FluorescentHallucinogen commented 2 years ago

@rodydavis I've found that if I select my own image via "Add you wallpaper" button, then when I switch from "Dynamic" to "Custom" tab, the extracted/calculated colors resets, so I can't see/copy/customize them.

rodydavis commented 2 years ago

This is working as intended. Dynamic tab is for just visualizing dynamic color, and the custom tab is for starting from baseline.

FluorescentHallucinogen commented 2 years ago

@rodydavis

This is working as intended. Dynamic tab is for just visualizing dynamic color, and the custom tab is for starting from baseline.

But this is not how Figma plug-in works. In Figma plug-in when user switch from "Dynamic" to "Custom" tab, the extracted/calculated colors are not reset, so they can customize them. And this is a very useful feature! Users expect the same behavior as in Figma plug-in.

FluorescentHallucinogen commented 2 years ago

@rodydavis Moreover, "support for keeping source colors between static/dynamic" is one of the features/fixes of yesterday's Figma plug-in release. ;)