search

material-foundation / material-theme-builder

Visualize dynamic color and create a custom Material Theme.
https://material-foundation.github.io/material-theme-builder/
Apache License 2.0
360 stars 27 forks source link

typography.module line-height variable is wrong #185

Closed miguelmoya1 closed 5 months ago

miguelmoya1 commented 11 months ago

Describe the bug

The typography.module autogenerated css file does not have some variables well set, such as in

.display-large {
    line-height: var(--md-sys-typescale-display-large-height);
{

should be the variable

--md-sys-typescale-display-large-line-height

and it generates it in all the same, both display, headline, title...

The variables:

letter-spacing: var(--md-sys-typescale-display-large-tracking);

It seems that also, in this case, it uses tracking but there is a variable called

--md-sys-typescale-title-large-letter-spacing

I don't know if the variable is badly generated or the css is taking the wrong variable. In both cases.

jwill commented 5 months ago

Thanks for the report.

At the present time, we're no longer generating typography in the versions under active development, neither Figma nor the web version at https://material-foundation.github.io/material-theme-builder/