material-foundation / material-theme-builder

Visualize dynamic color and create a custom Material Theme.
https://material-foundation.github.io/material-theme-builder/
Apache License 2.0
361 stars 27 forks source link

Color Tones no longer cleanly map to Color Roles #234

Open krunkled opened 6 months ago

krunkled commented 6 months ago

Describe the bug In the previous version, the colors used for Color Roles were easily mapped back to Color Tones 1 to 1 as described by the Material 3 color documentation. In the latest version, the colors used for Color Roles often do not map back to any of the Color Tones.

To Reproduce Steps to reproduce the behavior:

  1. Using latest playground file and launch latest material theme builder plugin.
  2. Using the default colors in the plugin choose "Update"
  3. Open the Sys > Light > Primary style config and reference the hex color.
  4. Open the Ref > Primary > primary 40 config and cross reference that color against the Primary style color
  5. These do not match.

Expected behavior The values represented by the Color Tones and Color Roles should match.

Screenshots image

Desktop (please complete the following information):

Smartphone (please complete the following information):

Additional context This issue is much easier to see when looking at variable mapping.

COLOR ROLES > VARIABLES image

COLOR TONES > VARIABLES image

COLOR MAPPING <> BETWEEN TONES AND ROLES TO BUILD TOKENS

PrattiDev commented 6 months ago

Same issue I encountered a long time ago, #82 . Subscribing to this! 🤞