search

material-foundation / material-theme-builder

Visualize dynamic color and create a custom Material Theme.
https://material-foundation.github.io/material-theme-builder/
Apache License 2.0
361 stars 27 forks source link

Inaccuracies in the colour styles generated by the plugin #251

Closed HimanshuGodara closed 5 months ago

HimanshuGodara commented 5 months ago

Describe the bug

System tokens generated by the plugin don't match the expected reference tokens. I've noticed this in the previous versions as well but ever since the latest update of v2.0.1 it has become much more evident. To Reproduce Steps to reproduce the behavior: Since the errors/inaccuracies are not consistent for all the different colour styles generated using different seed colours. I've included the example of colour styles generated by plugin when provided the seed colour value of: #008489

  1. Open a new/existing Figma File.
  2. Open the material theme builder plugin.
  3. Select create theme and wait for the process to complete.
  4. Provide the source colour value of #008489.
  5. Wait for the update process to complete.

Expected behavior At the end of token generation process we should expect the plugin to have generated both reference tokens and system tokens. The system tokens generated should match exactly with the reference tokens generated according to material design guidelines.

However there is noticeable inaccuracies in the system palette generated.

At this point, it should be mentioned that the inaccuracies found are different for different seed colour provided at the start of theme creation.

Screenshots Here are some screenshots to show the inaccuracies among the generated styles in Figma file. Screenshot 2024-01-22 at 7 42 04 PM Screenshot 2024-01-22 at 7 42 25 PM

For the following screenshots since I couldn't find the official documentation for the mapping system tokens to reference tokens the following screenshots only highlight those where the system tokens fail to match any reference tokens

Screenshot 2024-01-22 at 7 42 48 PM Screenshot 2024-01-22 at 7 43 03 PM Screenshot 2024-01-22 at 7 43 21 PM Screenshot 2024-01-22 at 7 43 35 PM

Desktop (please complete the following information):

Additional context If this outcome I'm experiencing is due to some error on my part please clarify before closing the issue. Otherwise, If there is any additional clarification required please let me know.

Hope this was helpful

HimanshuGodara commented 5 months ago

Closing this issue as it is similar to issue #234.