material-foundation / material-theme-builder

Visualize dynamic color and create a custom Material Theme.
https://material-foundation.github.io/material-theme-builder/
Apache License 2.0
357 stars 24 forks source link

Fixed Accents are not exported by the theme builder #281

Closed etyarews closed 1 week ago

etyarews commented 2 months ago

Describe the bug Fixed Accents are missing from the export options of both the Figma Tool and the Web Builder

To Reproduce Steps to reproduce the behavior:

  1. Go to a theme builder
  2. Click on 'export'
  3. Scroll down to any option
  4. See the files exported and see there's no fixed variation

Expected behavior The theme builder was updated recently and I was expecting it to generate all the tokens mentioned at m3.material.io

Additional context The Figma Tool itself generates the Fixed accent colors, and you are able to design components inside Figma using them, but they are missing when exporting, which complicates the hand-off between designer and programmer, as there's no alternative right now to the fixed accents

jwill commented 1 week ago

Fixed tones are not universally available on every platform. And even when available, they did not hit each platform at the same time. So they are exported in accordance to what a recent version of that platform has available.

If these tones are absolutely necessary and the platform/export doesn't have it, use extended color.

etyarews commented 1 week ago

It is part of the guidelines, how is it not planned?

And how the hell are we supposed to use extended colors for the same functionality as those fixed tones? The whole point of fixed tones is that they don't vary in relation to light/dark theme, extended tones do, they have nothing in common.

In my project, we had to create some truly unholy solution of using always using Color(dark) no matter the dark/light mode as a substitute for ContainerFixedDim.

This is all sorts of wrong and creates incredible confusion when explaining to the programmer that, despite Material Themes taking care of Light/Dark transition, we have certain elements that deliberately break from that.